nielsbross/Ink-Shader-Language
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Added comment and todo on resource index in type var.

Browse Source
This commit is contained in:
nielsbross
2025-09-18 11:02:35 +00:00
parent 3fdaebf66d
commit 4c84437022
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Check.jai
View File

@@ -7,6 +7,7 @@
// //
// [ ] Add and error for using keywords as names, or rename the dx11 keywords in the resulting hlsl shader. // [ ] Add and error for using keywords as names, or rename the dx11 keywords in the resulting hlsl shader.
// [ ] Add missing scope in for loop for loop iterator // [ ] Add missing scope in for loop for loop iterator
// [ ] Maybe we remove the resource index on type variables, seems like we don't need it there.
// [x] Improve error reporting on mismatched overloads when types don't match, but arity does. // [x] Improve error reporting on mismatched overloads when types don't match, but arity does.
// [x] Improve error reporting for type mismatches in general. It seems like the expect node is not always correct. // [x] Improve error reporting for type mismatches in general. It seems like the expect node is not always correct.
@@ -82,6 +83,10 @@ Type_Variable :: struct {
MAX_TYPE_VARIABLE_CHILDREN :: 32; MAX_TYPE_VARIABLE_CHILDREN :: 32;
children : Static_Array(Type_Variable_Handle, MAX_TYPE_VARIABLE_CHILDREN); children : Static_Array(Type_Variable_Handle, MAX_TYPE_VARIABLE_CHILDREN);
//@Incomplete: Should we remove this and do it in the output generation instead?
// Seems kind of superfluous considering we auto-generate it.
// Otherwise if we want to specify it, it should be specified as a hint @binding(index)
// In the case of using hints, we can just have it on the AST node.
//@Note(niels): For constant buffers //@Note(niels): For constant buffers
resource_index : u32; resource_index : u32;