nielsbross/Ink-Shader-Language
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Added todo regarding for loop scoping.

Browse Source
This commit is contained in:
nielsbross
2025-09-18 10:58:44 +00:00
parent 50a404984d
commit 3fdaebf66d
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Check.jai
View File

@@ -6,6 +6,7 @@
//~ nbr: Error reporting TODOs //~ nbr: Error reporting TODOs
// //
// [ ] Add and error for using keywords as names, or rename the dx11 keywords in the resulting hlsl shader. // [ ] Add and error for using keywords as names, or rename the dx11 keywords in the resulting hlsl shader.
// [ ] Add missing scope in for loop for loop iterator
// [x] Improve error reporting on mismatched overloads when types don't match, but arity does. // [x] Improve error reporting on mismatched overloads when types don't match, but arity does.
// [x] Improve error reporting for type mismatches in general. It seems like the expect node is not always correct. // [x] Improve error reporting for type mismatches in general. It seems like the expect node is not always correct.
@@ -1597,6 +1598,7 @@ check_node :: (checker : *Checker, node : *AST_Node) -> Type_Variable_Handle {
} }
case .For; { case .For; {
loop_iterator := node.token; loop_iterator := node.token;
// @Incomplete: Missing scope here?
symbol : Defined_Symbol; symbol : Defined_Symbol;
symbol.name = loop_iterator.ident_value; symbol.name = loop_iterator.ident_value;